[PATCH] D57427: [CodeGen][ObjC] Fix assert on calling `__builtin_constant_p` with ObjC objects.
Volodymyr Sapsai via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Feb 8 13:37:42 PST 2019
vsapsai added a comment.
In D57427#1386781 <https://reviews.llvm.org/D57427#1386781>, @hans wrote:
> What's the status of this patch? Is it something we should merge onto the 8.0 release branch?
Waiting on a one more review iteration from @ahatanak and hope that afterwards the patch should be good to go.
As for suitability for 8.0 release branch, I would ask @rjmccall for his opinion. As for me, I'm not entirely comfortable with CodeGen changes late in the release cycle. Also looks like in practice it shouldn't be a serious problem, `__builtin_constant_p` can be optimized out. For example, see https://godbolt.org/z/e1b4dB
CHANGES SINCE LAST ACTION
More information about the cfe-commits