[PATCH] D57961: [X86] Add explicit alignment to __m128/__m128i/__m128d/etc. to allow matching of MSVC behavior with #pragma pack.
Erich Keane via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Feb 8 10:09:59 PST 2019
erichkeane accepted this revision.
erichkeane added a comment.
This revision is now accepted and ready to land.
The justification is correct based on my research into this problem, and the code changes themselves look correct. I cannot think of any reason why re-stating the alignment will matter in GCC mode, so I think this is OK.
I'll accept, but I'd really like to give @rnk a chance to take a look to make sure there isn't something I'm missing.
Comment at: test/CodeGen/x86-vec-struct-packing.c:14
+static int a1[(sizeof(m128) == 32) - 1];
We default to C++14, do we not use static-asserts for this?
CHANGES SINCE LAST ACTION
More information about the cfe-commits