[PATCH] D57898: CodeGen: Fix PR40605: split constant structures generated by -ftrivial-auto-var-init when emitting initializators
Alexander Potapenko via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Feb 8 09:58:37 PST 2019
glider added a comment.
Re: case when STy != Loc.getElementType() - this is already covered by other Clang tests.
I'm still unsure about the heuristic here. I believe that for auto-initialization we want to be quite aggressive with these splits (unlike for regular constant stores).
Perhaps we should do the split in the case all bytes are pattern bytes? (This is probably another use case for `forInit`)
CHANGES SINCE LAST ACTION
More information about the cfe-commits