[PATCH] D57127: [analyzer] Port RetainSummaryManager to the new GenericCall interface, decouple ARCMT from the analyzer

Nico Weber via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Feb 8 06:36:25 PST 2019

thakis added a comment.
Herald added a project: clang.

Did you see the "Should we remove this check that currently requires ENABLE_ARCMT => ENABLE_SA? http://llvm-cs.pcc.me.uk/tools/clang/CMakeLists.txt#441" question?

In D57127#1373949 <https://reviews.llvm.org/D57127#1373949>, @george.karpenkov wrote:

> @thakis Sorry I don't understand your point. At the end of the day, ProgramPoint and BodyFarm are only used by the static analyzer.

They are used by StaticAnalyzer/Core, which clang does depend on.

> If you disagree, what is your proposed directory structure? What would be the benefits?

I'd put this in a library that isn't linked into clang. The benefit is that it's easier to keep clang itself small(er) that way.

  rC Clang



More information about the cfe-commits mailing list