[PATCH] D57267: [AST] Factor out the logic of the various Expr::Ignore*
Bruno Ricci via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Feb 8 06:13:01 PST 2019
riccibruno added subscribers: rnk, void.
riccibruno added a comment.
@void @rnk Perhaps you can comment on this: currently `Expr::IgnoreImpCasts` skips `FullExpr`s, but `Expr::IgnoreParenImpCasts` only skips (via `IgnoreParens`) `ConstantExpr`s. Is there any reason for this inconsistency ? I would like to add `FullExpr` to the nodes skipped by `IgnoreParenImpCasts` for consistency but I am worried about unexpected issues even though all tests pass.
CHANGES SINCE LAST ACTION
More information about the cfe-commits