[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in clang
Jennifer Yu via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Feb 7 21:42:36 PST 2019
jyu2 added inline comments.
Comment at: lib/Analysis/CFG.cpp:3137
+ Block = createBlock(false);
> efriedma wrote:
> > Passing add_successor=false seems suspect; this could probably use more test coverage.
> Did you ever look at this?
Sorry, I missed this.
Yes. add_successor has to be true, since asm goto is kind of contional goto. I changed.
CHANGES SINCE LAST ACTION
More information about the cfe-commits