[PATCH] D57464: Generalize method overloading on addr spaces to C++

John McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Feb 7 19:30:19 PST 2019


rjmccall added a reviewer: rsmith.
rjmccall added a comment.

Hmm.  Richard, I've mostly let you stay out of this, but do you have any thoughts about the right manage to parse attributes here?  We want to allow `address_space` attributes to be written in the method-qualifiers list, but when we do that, it's hard to avoid parsing arbitrary attributes and then potentially needing to move them to the declarator; also, doing that might mean propagating awkward information in to deal with of delayed attribute parsing.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57464/new/

https://reviews.llvm.org/D57464





More information about the cfe-commits mailing list