[PATCH] D57915: [COFF, ARM64] Remove definitions for _byteswap library functions

Eli Friedman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Feb 7 15:47:46 PST 2019


efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.

I guess we can track inlining separately, if you want to merge this quickly to unblock the Chrome build.  LGTM

> the former provides global declaration which seems inherited by the definition in intrin.h.

This is a bug, actually; we support a non-standard Microsoft extension for mismatched "static" markings, but the "static" is supposed to win.

Please make sure to file bugs for both the wrong linkage and inlining bswap.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57915/new/

https://reviews.llvm.org/D57915





More information about the cfe-commits mailing list