[PATCH] D56943: [clang-format][NFC] Allow getLLVMStyle() to take a language
Kristina Brooks via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Feb 6 19:46:24 PST 2019
kristina added a comment.
The patch itself looks sound. However given that you have a specific use case in mind (TableGen files) could you provide supplementary coverage for that specific use case (unit tests for formatting `td` syntax using `format::getLLVMStyle(format::FormatStyle::LK_TableGen)`? I'm not entirely sure how useful this particular change is given that there's no linked patches related to your use case, I think adding those would help as well (possibly as a separate dependent patchset).
CHANGES SINCE LAST ACTION
More information about the cfe-commits