[PATCH] D57831: AMDGPU: set wchar_t and wint_t to be unsigned short on windows

Saleem Abdulrasool via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Feb 6 11:38:08 PST 2019


compnerd requested changes to this revision.
compnerd added inline comments.
This revision now requires changes to proceed.


================
Comment at: lib/Basic/Targets/AMDGPU.cpp:263
   MaxAtomicPromoteWidth = MaxAtomicInlineWidth = 64;
+#if _WIN32
+  WCharType = UnsignedShort;
----------------
This seems wrong.  This means that if you built on Linux, you get a different `wchar_t` type.  You should be checking the triple and setting this accordingly.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57831/new/

https://reviews.llvm.org/D57831





More information about the cfe-commits mailing list