[PATCH] D57829: [HIP] Disable emitting llvm.linker.options in device compilation

Wed Feb 6 11:29:56 PST 2019

tra added a comment.

In D57829#1387416 <https://reviews.llvm.org/D57829#1387416>, @yaxunl wrote:

> In D57829#1387412 <https://reviews.llvm.org/D57829#1387412>, @tra wrote:
>
> > Could you elaborate on why you want to disable this metadata? I think the original idea of llvm.linker.options was that it should be ignored if the back-end does not support it.
>
>
> If backend does not support it, it goes to TargetLoweringObjectFileELF::emitModuleMetadata and causes codegen to fail.

Fails how? AFAICT, for llvm.linker.options  emitModuleMetadata() just creates an ELF section ".linker-options" which should just work.
Are you saying that some of HIP tools can't deal with the unknown section type?

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57829/new/

https://reviews.llvm.org/D57829