[PATCH] D57798: [WebAssembly] Add atomics target option

Thomas Lively via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Feb 5 17:36:59 PST 2019


tlively accepted this revision.
tlively added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: lib/Basic/Targets/WebAssembly.cpp:172
+    }
+    if (Feature == "0atomics") {
+      HasAtomics = false;
----------------
tlively wrote:
> -atomics
You won the race!


================
Comment at: test/Preprocessor/wasm-target-features.c:89
+// BLEEDING-EDGE-DAG:#define __wasm_simd128__ 1{{$}}
+// BLEEDING-EDGE-DAG:#define __wasm_atomics__ 1{{$}}
 // BLEEDING-EDGE-NOT:#define __wasm_unimplemented_simd128__ 1{{$}}
----------------
Nice.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57798/new/

https://reviews.llvm.org/D57798





More information about the cfe-commits mailing list