[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in clang

Craig Topper via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Feb 5 10:45:04 PST 2019


craig.topper added a subscriber: jyknight.
craig.topper added inline comments.


================
Comment at: lib/CodeGen/CGStmt.cpp:2236
+    llvm::CallBrInst *Result =
+        Builder.CreateCallBr(FTy, IA, Fallthrough, Transfer, Args);
+    UpdateAsmCallInst(cast<llvm::CallBase>(*Result), HasSideEffect, ReadOnly,
----------------
I don't think we need to pass FTy here now. I made that change before @jyknight added FunctionCallee that should be able to find the type from the InlineAsm. The CallBr IRBuilder code should have a FunctionCallee Create function as of yesterday.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56571/new/

https://reviews.llvm.org/D56571





More information about the cfe-commits mailing list