[PATCH] D56924: Handle ObjCCategoryDecl class extensions for print
David Goldman via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Feb 5 10:19:44 PST 2019
dgoldman added a comment.
In D56924#1379342 <https://reviews.llvm.org/D56924#1379342>, @arphaman wrote:
> Do you know if this have an effect on the output of completion results or other tooling-based output?
> A couple of requests:
> - This behavior should be controlled by a printing policy flag `SupressUnwrittenScope` (specifically for the '::(class extension)').
> - I also agree with Sam's comment. The property should still be qualified by the class name as well, e.g. `Obj::(class extension)::property`.
It's possible - clangd for instance was crashing because of the current behavior: ::property instead of Obj::property or (class extension)::property.
- Added although see below
- I've modified this to be more in line with the current handling of Objc methods, but this no longer outputs the "(class extension)", do you think it should output both?
CHANGES SINCE LAST ACTION
More information about the cfe-commits