[PATCH] D57739: [clangd] Format tweak's replacements.
Ilya Biryukov via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Feb 5 09:08:57 PST 2019
ilya-biryukov added a comment.
In D57739#1385144 <https://reviews.llvm.org/D57739#1385144>, @hokein wrote:
> This seems introduce intrusive changes to the Tweak interface (Tweak will need to know the `FormatStyle` somehow), I think this might be done in another patch.
It's totally fine, since we have just a single tweak now and changing the interface costs nothing.
The important part is making it **hard** to misuse the interface and forcing formatting on all the users of the interface is a significant burden. E.g. other users of `ClangdServer` (tests, users of clangd C++ API) shouldn't worry about formatting on their own.
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
More information about the cfe-commits