[PATCH] D57664: [opaque pointer types] Fix the CallInfo passed to EmitCall in some edge cases.
James Y Knight via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Feb 4 18:52:17 PST 2019
jyknight marked an inline comment as done.
jyknight added inline comments.
Comment at: clang/lib/CodeGen/CGCall.cpp:3837
+ // having pointee types).
+ llvm::FunctionType *IRFuncTyFromInfo = getTypes().GetFunctionType(CallInfo);
+ assert(IRFuncTy == IRFuncTyFromInfo);
> This will be warned as unused in a release build.
> Would this be hideous if it's just all one big assert?
> assert((CallInfo.isVariadic && CallInfo.getArgStruct) || IRFuncTy == getTypes().GetFunctionType(CallInfo));
> (I think that's accurate?)
Clearer IMO to just put #ifndef NDEBUG around the block, so I'll do that.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the cfe-commits