[PATCH] D57642: [X86] Update clobber list in a test after D57641. Remove filter for 'fpsw' in MS inline asm clobber list generation since the backend now uses 'fpsr'.

Reid Kleckner via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Feb 4 15:14:45 PST 2019


rnk added inline comments.


================
Comment at: lib/Parse/ParseStmtAsm.cpp:637-639
   // constraints. Clang always adds fpsr to the clobber list anyway.
   llvm::erase_if(Clobbers, [](const std::string &C) {
+    return C == "mxcsr";
----------------
In light of this comment about "clang always adding fpsr anyway" I'd rather keep the fpsr filter here.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57642/new/

https://reviews.llvm.org/D57642





More information about the cfe-commits mailing list