[PATCH] D57532: [Index] Make sure c-index-test finds libc++ on Mac

Fri Feb 1 11:05:32 PST 2019

arphaman added a comment.

In D57532#1380383 <https://reviews.llvm.org/D57532#1380383>, @ilya-biryukov wrote:

> @arphaman, thanks for pointing this out. It's definitely nice to change stuff only in one place.
>  There are two issues still pending:
>
> - `index-file.cu` still fails, I haven't looked into it closely yet, any idea why that might be happening?; repro is simple, just patch this in locally and run the test.

No idea why it fails, I'll try to take a look.

> - I'm not sure it's safe to use temporary storage for `argv[0]` in `clang_parseTranslationUnit2`. The resulting translation units probably holds references to `argv` and is free to read the data later. A simple and safe alternative would be to store this string in `CIndexer` and return a reference here. Does that LG?

Yes, that would be better. Let's store the string in CIndexer like we do for toolchain path and the resource dir.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57532/new/

https://reviews.llvm.org/D57532