[PATCH] D57521: [CMake] External compiler-rt-configure requires LLVMTestingSupport when including tests

Stefan Gränitz via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Feb 1 04:25:18 PST 2019


sgraenitz added a comment.

In D57521#1379837 <https://reviews.llvm.org/D57521#1379837>, @beanz wrote:

> @phosek, does LLVM’s runtime directory do this correctly?
>
> At some point we should try and deprecate and remove this option in favor of the LLVM directory because the LLVM approach is much more complete and robust.


My 2¢: ideally compiler-rt used imported targets. Please see my note added in D55891 <https://reviews.llvm.org/D55891>.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57521/new/

https://reviews.llvm.org/D57521





More information about the cfe-commits mailing list