[PATCH] D57527: Do not copy floating pointer format from aux target

Yaxun Liu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jan 31 11:09:29 PST 2019


yaxunl added a comment.

In D57527#1379065 <https://reviews.llvm.org/D57527#1379065>, @rjmccall wrote:

> Okay, so you silently have an incompatible ABI for anything in the system headers that mentions `long double`.  Do you have any plans to address or work around that, or is the hope that it just doesn't matter?
>
> I feel like this should be a special case for AMDGPU rather than a general behavior with aux targets.


If host do not pass long double to device we will be fine. So we need to diagnose long double kernel arguments. However I'd like to do it in separate patch since we want to fix the regression first.

Since this maybe a special case for AMDGPU, I will fix it in AMDGPUTargetInfo.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57527/new/

https://reviews.llvm.org/D57527





More information about the cfe-commits mailing list