[PATCH] D57100: [clang-tidy] refactor bugprone-exception-escape analysis into class

Thu Jan 31 02:40:48 PST 2019

JonasToth added a comment.

In D57100#1377687 <https://reviews.llvm.org/D57100#1377687>, @baloghadamsoftware wrote:

> In D57100#1373440 <https://reviews.llvm.org/D57100#1373440>, @JonasToth wrote:
>
> > @baloghadamsoftware Do you see any problems with the refactoring, especially the new `FunctionDecl*`-Caching is not exactly a refactoring. If you have any thoughts on that would be great to hear!
>
>
> Yes, it looks a good improvement, I expect another huge speedup. (We had a previous huge speedup after I optimized the matcher expression in 7.0.1 because in 7.0.0 it seemed to hang, it was really bad).

I revisited the reproducer for that bug and there was no bigger performance gain with the new version in bugprone-exception-escape. But it didnt get worse either :)

Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57100/new/

https://reviews.llvm.org/D57100