[PATCH] D57487: [CUDA] Propagate detected version of CUDA to cc1

Justin Lebar via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jan 30 16:56:06 PST 2019


jlebar accepted this revision.
jlebar added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang/include/clang/Basic/Cuda.h:108
+enum class CudaFeature {
+  CUDA_USES_NEW_LAUNCH,
+};
----------------
Should this enum be documented?


================
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3475
+      if (IsCuda) {
+        // We need to figure out which CUDA version we're compiling for as that
+        // determines how we load and launch GPU kernels.
----------------
nit, s/as/, as/


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57487/new/

https://reviews.llvm.org/D57487





More information about the cfe-commits mailing list