[PATCH] D57325: [clangd] Collect macros in static index.

Haojian Wu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jan 30 03:37:54 PST 2019


hokein marked an inline comment as done.
hokein added inline comments.


================
Comment at: unittests/clangd/BackgroundIndexTests.cpp:128
       runFuzzyFind(Idx, ""),
       UnorderedElementsAre(Named("common"), Named("A_CC"), Named("g"),
                            AllOf(Named("f_b"), Declared(), Not(Defined()))));
----------------
kadircet wrote:
> Shouldn't we also have `Named("A")` in here ?
The symbol `A` is filtered out (as it is defined via a compile command-line option `-DA=1`).


Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57325/new/

https://reviews.llvm.org/D57325





More information about the cfe-commits mailing list