[PATCH] D56935: [NewPM] Add support for new-PM plugins to clang

Sat Jan 26 14:32:33 PST 2019

melver added a comment.

In D56935#1370861 <https://reviews.llvm.org/D56935#1370861>, @philip.pfaffe wrote:

> It would be good to check, since the bots won't! Otherwise this looks good.

Thanks!

I attempted to test on Windows, but noticed that for a shared library CMake already reports "Loadable modules not supported on this platform", and couldn't create a real plugin. In any case, I attempted to load an arbitrary DLL to see if errors are reported correctly and subsequently improved that. If a library can't be loaded, it will not fail silently now.

If you're happy with this version, I would need you to land this for me (I do not have commit access). Many thanks!

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56935/new/

https://reviews.llvm.org/D56935