[PATCH] D57113: [clang-tidy] openmp-use-default-none - a new module and a check

[Alexey Bataev via Phabricator via cfe-commits]

ABataev added inline comments.


================
Comment at: clang-tidy/openmp/UseDefaultNoneCheck.cpp:113
+void UseDefaultNoneCheck::registerMatchers(MatchFinder *Finder) {
+  // If OpenMP is not enabled, don't register the check, it won't find anything.
+  if (!getLangOpts().OpenMP)
----------------
JonasToth wrote:
> Is that the case? Will the pragmas be ignored if non-omp?
> 
> You could reorder that sentence `Don't register the check if OpenMP is not enabled as the directives are not considered in the AST.` or so.
If OpenMP is disabled, the pragmas are just completely ignored.


Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57113/new/

https://reviews.llvm.org/D57113