[PATCH] D56984: [libunwind] Silence warnings about unused parameters

Martin Storsjö via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jan 22 12:50:58 PST 2019


mstorsjo added a comment.

In D56984#1366297 <https://reviews.llvm.org/D56984#1366297>, @ldionne wrote:

> LGTM, but would it make sense to have a macro like `_LIBUNWIND_MAYBE_UNUSED(var)` instead?


I guess some macro like that could be ok as well, although I think the `(void)var` is a rather well-known pattern in itself.


Repository:
  rUNW libunwind

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56984/new/

https://reviews.llvm.org/D56984





More information about the cfe-commits mailing list