[PATCH] D56967: Thread safety analysis: Improve diagnostics for double locking

Aaron Puchert via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jan 21 14:29:04 PST 2019


aaronpuchert marked 2 inline comments as done.
aaronpuchert added a comment.

Thanks for the review! I'll commit this when I have commit access again, which is waiting for my employer's approval to the relicensing.



================
Comment at: lib/Sema/AnalysisBasedWarnings.cpp:1693
+                                         << Kind << LockName);
+    OptionalNotes notes =
+        LocLocked.isValid()
----------------
I'll assume it's also `Notes` then. I tend to subconsciously forget these things.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56967/new/

https://reviews.llvm.org/D56967





More information about the cfe-commits mailing list