[PATCH] D56892: Add a priority field to availability attributes to prioritize explicit attributes from declaration over attributes from '#pragma clang attribute'

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jan 21 07:38:24 PST 2019


aaron.ballman accepted this revision.
aaron.ballman added a comment.

LGTM with a suggested edit for the docs (which look great, btw!).



================
Comment at: include/clang/Basic/AttrDocs.td:1252
+  
+For platforms like ``watchOS`` and ``tvOS`` whose availability attributes can
+be implicitly inferred from an ``iOS`` availability attribute the logic is
----------------
tvOS whose -> tvOS, whose


================
Comment at: include/clang/Basic/AttrDocs.td:1253
+For platforms like ``watchOS`` and ``tvOS`` whose availability attributes can
+be implicitly inferred from an ``iOS`` availability attribute the logic is
+slightly more complex. The explicit and the pragma-applied availability
----------------
attribute the logic -> attribute, the logic


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56892/new/

https://reviews.llvm.org/D56892





More information about the cfe-commits mailing list