[PATCH] D55256: [clangd] Support clang-tidy configuration in clangd.

[Haojian Wu via Phabricator via cfe-commits]

hokein added inline comments.


================
Comment at: clangd/tool/ClangdMain.cpp:438
+  auto OverrideClangTidyOptions = tidy::ClangTidyOptions::getDefaults();
+  if (!ClangTidyChecks.empty())
+    OverrideClangTidyOptions.Checks = ClangTidyChecks;
----------------
sammccall wrote:
> This prevents `-clang-tidy-checks=` from disabling all checks.
> use ClangTidyChecks.getNumOccurrences() instead?
To disable all checks, the `-clang-tidy-checks` should be `-*`. clang-tidy merges all configurations.

Actually we don't need this `if`, removed.


Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55256/new/

https://reviews.llvm.org/D55256