[PATCH] D56358: [AST] Move back BasePathSize to the bit-fields of CastExpr

Roman Lebedev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Jan 5 13:14:41 PST 2019


lebedev.ri added inline comments.


================
Comment at: include/clang/AST/Expr.h:3029
+    assert((CastExprBits.BasePathSize == BasePathSize) &&
+           "BasePathSize overflow!");
     assert(CastConsistency());
----------------
riccibruno wrote:
> It cannot overflow now, but someone in the future is going
> to shrink `CastExprBitfields::BasePathSize`.
Can you move that static assert here instead of deleting it?


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56358/new/

https://reviews.llvm.org/D56358





More information about the cfe-commits mailing list