[PATCH] D56358: [AST] Move back BasePathSize to the bit-fields of CastExpr

Bruno Ricci via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Jan 5 13:07:21 PST 2019


riccibruno marked 2 inline comments as done.
riccibruno added inline comments.


================
Comment at: include/clang/AST/Expr.h:3029
+    assert((CastExprBits.BasePathSize == BasePathSize) &&
+           "BasePathSize overflow!");
     assert(CastConsistency());
----------------
It cannot overflow now, but someone in the future is going
to shrink `CastExprBitfields::BasePathSize`.


================
Comment at: include/clang/AST/Stmt.h:487
+    /// here. ([implimits] Direct and indirect base classes [16384]).
+    unsigned BasePathSize;
   };
----------------
Feel free to find a better comment here.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56358/new/

https://reviews.llvm.org/D56358





More information about the cfe-commits mailing list