[PATCH] D55656: [OpenCL] Address space for default class members
John McCall via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Dec 17 12:08:20 PST 2018
rjmccall added inline comments.
Comment at: lib/AST/ASTContext.cpp:2781
+ return getAddrSpaceQualType(NewT, Orig.getAddressSpace());
> rjmccall wrote:
> > You're trying to handle a method qualifier, not a type a functions that are themselves in some non-standard address space, right? The method qualifier should already be part of `Proto->getExtProtoInfo()`, so if there's an address space qualifier out here, something is very wrong.
> As far as I understand the new design, we have an address space qualifier on a method and as a part of the function prototype too. Are you saying that we need to make sure the prototype has an address space too?
The address-space `this` qualifiers are a part of `FunctionProtoType` that's totally independent from the storage of top-level qualifiers that's part of `QualType`. `Orig.getAddressSpace()` is asking about the top-level qualifiers, not the `this` qualifiers. Generally, function types should not have top-level qualifiers at all (although of course a member pointer can have both top-level qualifiers and `this` qualifiers, with the former meaning something completely different from the latter).
CHANGES SINCE LAST ACTION
More information about the cfe-commits