[PATCH] D55656: [OpenCL] Address space for default class members
Anastasia Stulova via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Dec 17 05:20:24 PST 2018
Anastasia added inline comments.
Comment at: lib/AST/ASTContext.cpp:2781
+ return getAddrSpaceQualType(NewT, Orig.getAddressSpace());
> You're trying to handle a method qualifier, not a type a functions that are themselves in some non-standard address space, right? The method qualifier should already be part of `Proto->getExtProtoInfo()`, so if there's an address space qualifier out here, something is very wrong.
As far as I understand the new design, we have an address space qualifier on a method and as a part of the function prototype too. Are you saying that we need to make sure the prototype has an address space too?
CHANGES SINCE LAST ACTION
More information about the cfe-commits