[PATCH] D55410: [clang-tidy] check for flagging using declarations in headers

Shyan Akmal via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Dec 12 08:50:07 PST 2018


Naysh marked an inline comment as done.
Naysh added inline comments.


================
Comment at: docs/clang-tidy/checks/abseil-alias-free-headers.rst:13
+The style guide  http://google.github.io/styleguide/cppguide.html#Aliases discusses this
+issue in more detail
----------------
aaron.ballman wrote:
> Eugene.Zelenko wrote:
> > Naysh wrote:
> > > Eugene.Zelenko wrote:
> > > > Missing link to guidelines,
> > > @Eugene.Zelenko: Sorry, I'm not sure what you mean. Could you clarify what guidelines you're referring to? 
> > Please see documentation in other using-related checks.
> I think he's talking about the fact that this is text and not a hyperlink. It should look something more like
> ```
> The `Abseil Style Guide <http://google.github.io/styleguide/cppguide.html#Aliases>`_ discusses this issue in more detail.
> ```
Ah okay, that makes sense. Thanks for your help!


Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55410/new/

https://reviews.llvm.org/D55410





More information about the cfe-commits mailing list