[PATCH] D55447: [Sema] Fix Modified Type in address_space AttributedType

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Dec 10 05:14:01 PST 2018


aaron.ballman requested changes to this revision.
aaron.ballman added a comment.
This revision now requires changes to proceed.

Missing test cases.



================
Comment at: clang/lib/Sema/SemaType.cpp:5747
+static bool BuildAddressSpaceIndex(LangAS &ASIdx, const Expr *AddrSpace,
+                                   SourceLocation AttrLoc, Sema &S) {
   if (!AddrSpace->isValueDependent()) {
----------------
I think we usually pass the `Sema` argument first in these helper methods.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55447/new/

https://reviews.llvm.org/D55447





More information about the cfe-commits mailing list