[PATCH] D54995: [MemoryBuffer] By default assume that all files are volatile to prevent unintended file locks

Wed Nov 28 09:19:05 PST 2018

ilya-biryukov added a comment.

In D54995#1311427 <https://reviews.llvm.org/D54995#1311427>, @zturner wrote:

> My first thought would be that it depends on the flags to CreateFile moreso (and perhaps entirely) rather than the flags to MapViewOfFile or CreateFileMapping.  Specifically, the `FILE_SHARE_XXX` flags are the most relevant here.

That was my initial thought as well and it worked fine on Windows Server 2012. Will have to do it again to double-check, though, not sure I can dig up that code.

In D54995#1311419 <https://reviews.llvm.org/D54995#1311419>, @yvvan wrote:

> https://bugreports.qt.io/browse/QTCREATORBUG-15449
>  I was able to lock files last time with mmap. The Windows API calls are CreateFileMappingW (it's in the Path.inc, line 794) and MapViewOfFile (further down). As far as I remember the second call actually creates the lock and is freed only by UnmapViewOfFile in destructor

Thanks. I think I did the same on Windows Server 2012 and it didn't lock the files. I'll try to repeat my experiments.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54995/new/

https://reviews.llvm.org/D54995