[PATCH] D54995: [MemoryBuffer] By default assume that all files are volatile to prevent unintended file locks

[Zachary Turner via Phabricator via cfe-commits]

zturner added a comment.

In D54995#1311399 <https://reviews.llvm.org/D54995#1311399>, @ilya-biryukov wrote:

> In D54995#1311303 <https://reviews.llvm.org/D54995#1311303>, @yvvan wrote:
>
> > "could we figure out the exact cause of the issue?"
> >  And this review was not meant to proceed immediately but rather state the intention and get some feedback because I still don't know answers to the questions 1 and 2 (did somebody else investigate that?)
>
>
> I tried calling Windows APIs that LLVM uses with multiple combinations of flags and couldn't make it lock the file. But maybe I didn't arrive at the right combination of flags or was trying on a different version.
>
> Could you send a link for the issue itself, I'm not sure how to get from the attachment to an actual issue, would be interested to look at this


My first thought would be that it depends on the flags to CreateFile moreso (and perhaps entirely) rather than the flags to MapViewOfFile or CreateFileMapping.  Specifically, the `FILE_SHARE_XXX` flags are the most relevant here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54995/new/

https://reviews.llvm.org/D54995