[PATCH] D53001: [Driver] check for exit code from SIGPIPE

Nick Desaulniers via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 8 15:56:24 PDT 2018


nickdesaulniers added inline comments.


================
Comment at: lib/Driver/Driver.cpp:1406
+    // for SIGPIPE. Do not print diagnostics for this case.
+    if (Res == 71)
+      continue;
----------------
jfb wrote:
> jfb wrote:
> > Ditto on magical number in a header.
> I think you want to create a new diagnostic here for "broken pipe" before the `continue`.
Won't the diagnostic always be printed then? I thought we were trying to silence all related warnings?


Repository:
  rC Clang

https://reviews.llvm.org/D53001





More information about the cfe-commits mailing list