[PATCH] D53001: [Driver] check for exit code from SIGPIPE

JF Bastien via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 8 15:41:08 PDT 2018


jfb added a comment.

What's the return code of the driver when the pipe is broken that way?



================
Comment at: lib/Driver/Driver.cpp:1406
+    // for SIGPIPE. Do not print diagnostics for this case.
+    if (Res == 71)
+      continue;
----------------
Ditto on magical number in a header.


================
Comment at: lib/Driver/Driver.cpp:1406
+    // for SIGPIPE. Do not print diagnostics for this case.
+    if (Res == 71)
+      continue;
----------------
jfb wrote:
> Ditto on magical number in a header.
I think you want to create a new diagnostic here for "broken pipe" before the `continue`.


Repository:
  rC Clang

https://reviews.llvm.org/D53001





More information about the cfe-commits mailing list