[PATCH] D50246: [RISCV] Add support for computing sysroot for riscv32-unknown-elf

[Kristina Brooks via Phabricator via cfe-commits]

kristina added a comment.

In https://reviews.llvm.org/D50246#1229068, @rogfer01 wrote:

> Thanks for reopening this @kristina.
>
> I suggest passing `--sysroot=` to make sure we see the expected behaviour when the sysroot is actually empty.
>
> Note that this would not really test the scenario where `DEFAULT_SYSROOT` is empty **and** no `--sysroot` appears in the command line. I'm not sure if we really want to test that case (but if we do, I think we will have to move that case into a test of its own and add a //feature// in `lit.cfg.py` that describes that clang does not have any built-in default sysroot).
>
> Thoughts?


Seems like a fairly niche case, you can request changes to this revision but there's been no regressions otherwise, buildbots have been handling this fine.

I think this may be something that would belong in a separate diff for the test suite, not for this particular diff. You can always just submit a diff for the test suite if you think it should have that option and if it would be useful as a general thing.


Repository:
  rC Clang

https://reviews.llvm.org/D50246