[PATCH] D50246: [RISCV] Add support for computing sysroot for riscv32-unknown-elf

Roger Ferrer Ibanez via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Sep 10 09:45:04 PDT 2018


rogfer01 added a comment.

Thanks for reopening this @kristina.

I suggest passing `--sysroot=` to make sure we see the expected behaviour when the sysroot is actually empty.

Note that this would not really test the scenario where `DEFAULT_SYSROOT` is empty **and** no `--sysroot` appears in the command line. I'm not sure if we really want to test that case (but if we do, I think we will have to move that case into a test of its own and add a //feature// in `lit.cfg.py` that describes that clang does not have any built-in default sysroot).

Thoughts?


Repository:
  rC Clang

https://reviews.llvm.org/D50246





More information about the cfe-commits mailing list