[PATCH] D50130: [libc++] Fix build failures after merging <charconv>

[Zhihao Yuan via Phabricator via cfe-commits]

This revision was not accepted when it landed; it landed in state "Needs Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rCXX338486: [libc++] Fix build failures after merging <charconv> (authored by lichray, committed by ).

Changed prior to commit:
  https://reviews.llvm.org/D50130?vs=158464&id=158465#toc

Repository:
  rCXX libc++

https://reviews.llvm.org/D50130

Files:
  lib/abi/x86_64-unknown-linux-gnu.v1.abilist
  test/std/utilities/charconv/charconv.from.chars/integral.pass.cpp
  test/support/charconv_test_helpers.h


Index: test/support/charconv_test_helpers.h
===================================================================
--- test/support/charconv_test_helpers.h
+++ test/support/charconv_test_helpers.h
@@ -178,7 +178,7 @@
             {
                 assert(x == 0xc);
                 assert(r2.ptr == buf);
-                assert(r.ec == std::errc::invalid_argument);
+                assert(r2.ec == std::errc::invalid_argument);
             }
             else
             {
Index: test/std/utilities/charconv/charconv.from.chars/integral.pass.cpp
===================================================================
--- test/std/utilities/charconv/charconv.from.chars/integral.pass.cpp
+++ test/std/utilities/charconv/charconv.from.chars/integral.pass.cpp
@@ -37,6 +37,7 @@
             using xl = std::numeric_limits<T>;
 
             test(1, b);
+            test(-1, b);
             test(xl::lowest(), b);
             test((xl::max)(), b);
             test((xl::max)() / 2, b);
Index: lib/abi/x86_64-unknown-linux-gnu.v1.abilist
===================================================================
--- lib/abi/x86_64-unknown-linux-gnu.v1.abilist
+++ lib/abi/x86_64-unknown-linux-gnu.v1.abilist
@@ -1192,6 +1192,8 @@
 {'name': '_ZNSt3__15wclogE', 'is_defined': True, 'type': 'OBJECT', 'size': 160}
 {'name': '_ZNSt3__15wcoutE', 'is_defined': True, 'type': 'OBJECT', 'size': 160}
 {'name': '_ZNSt3__16__clocEv', 'is_defined': True, 'type': 'FUNC'}
+{'name': '_ZNSt3__16__itoa8__u64toaEmPc', 'is_defined': True, 'type': 'FUNC'}
+{'name': '_ZNSt3__16__itoa8__u32toaEjPc', 'is_defined': True, 'type': 'FUNC'}
 {'name': '_ZNSt3__16__sortIRNS_6__lessIaaEEPaEEvT0_S5_T_', 'is_defined': True, 'type': 'FUNC'}
 {'name': '_ZNSt3__16__sortIRNS_6__lessIccEEPcEEvT0_S5_T_', 'is_defined': True, 'type': 'FUNC'}
 {'name': '_ZNSt3__16__sortIRNS_6__lessIddEEPdEEvT0_S5_T_', 'is_defined': True, 'type': 'FUNC'}


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D50130.158465.patch
Type: text/x-patch
Size: 1900 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20180801/1ad2c7cf/attachment.bin>