[libcxx] r338486 - [libc++] Fix build failures after merging <charconv>

Zhihao Yuan via cfe-commits cfe-commits at lists.llvm.org
Tue Jul 31 22:21:26 PDT 2018


Author: lichray
Date: Tue Jul 31 22:21:26 2018
New Revision: 338486

URL: http://llvm.org/viewvc/llvm-project?rev=338486&view=rev
Log:
[libc++] Fix build failures after merging <charconv>

Summary:
- fix a stupid unit test typo
- add <charconv> symbols to Linux abilist

Reviewers: EricWF

Subscribers: christof, ldionne, cfe-commits

Differential Revision: https://reviews.llvm.org/D50130

Modified:
    libcxx/trunk/lib/abi/x86_64-unknown-linux-gnu.v1.abilist
    libcxx/trunk/test/std/utilities/charconv/charconv.from.chars/integral.pass.cpp
    libcxx/trunk/test/support/charconv_test_helpers.h

Modified: libcxx/trunk/lib/abi/x86_64-unknown-linux-gnu.v1.abilist
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/lib/abi/x86_64-unknown-linux-gnu.v1.abilist?rev=338486&r1=338485&r2=338486&view=diff
==============================================================================
--- libcxx/trunk/lib/abi/x86_64-unknown-linux-gnu.v1.abilist (original)
+++ libcxx/trunk/lib/abi/x86_64-unknown-linux-gnu.v1.abilist Tue Jul 31 22:21:26 2018
@@ -1192,6 +1192,8 @@
 {'name': '_ZNSt3__15wclogE', 'is_defined': True, 'type': 'OBJECT', 'size': 160}
 {'name': '_ZNSt3__15wcoutE', 'is_defined': True, 'type': 'OBJECT', 'size': 160}
 {'name': '_ZNSt3__16__clocEv', 'is_defined': True, 'type': 'FUNC'}
+{'name': '_ZNSt3__16__itoa8__u64toaEmPc', 'is_defined': True, 'type': 'FUNC'}
+{'name': '_ZNSt3__16__itoa8__u32toaEjPc', 'is_defined': True, 'type': 'FUNC'}
 {'name': '_ZNSt3__16__sortIRNS_6__lessIaaEEPaEEvT0_S5_T_', 'is_defined': True, 'type': 'FUNC'}
 {'name': '_ZNSt3__16__sortIRNS_6__lessIccEEPcEEvT0_S5_T_', 'is_defined': True, 'type': 'FUNC'}
 {'name': '_ZNSt3__16__sortIRNS_6__lessIddEEPdEEvT0_S5_T_', 'is_defined': True, 'type': 'FUNC'}

Modified: libcxx/trunk/test/std/utilities/charconv/charconv.from.chars/integral.pass.cpp
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/std/utilities/charconv/charconv.from.chars/integral.pass.cpp?rev=338486&r1=338485&r2=338486&view=diff
==============================================================================
--- libcxx/trunk/test/std/utilities/charconv/charconv.from.chars/integral.pass.cpp (original)
+++ libcxx/trunk/test/std/utilities/charconv/charconv.from.chars/integral.pass.cpp Tue Jul 31 22:21:26 2018
@@ -37,6 +37,7 @@ struct test_basics : roundtrip_test_base
             using xl = std::numeric_limits<T>;
 
             test(1, b);
+            test(-1, b);
             test(xl::lowest(), b);
             test((xl::max)(), b);
             test((xl::max)() / 2, b);

Modified: libcxx/trunk/test/support/charconv_test_helpers.h
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/support/charconv_test_helpers.h?rev=338486&r1=338485&r2=338486&view=diff
==============================================================================
--- libcxx/trunk/test/support/charconv_test_helpers.h (original)
+++ libcxx/trunk/test/support/charconv_test_helpers.h Tue Jul 31 22:21:26 2018
@@ -178,7 +178,7 @@ struct roundtrip_test_base
             {
                 assert(x == 0xc);
                 assert(r2.ptr == buf);
-                assert(r.ec == std::errc::invalid_argument);
+                assert(r2.ec == std::errc::invalid_argument);
             }
             else
             {




More information about the cfe-commits mailing list