[PATCH] D46651: [OpenCL] Support new/delete in Sema

[John McCall via Phabricator via cfe-commits]

rjmccall accepted this revision.
rjmccall added a comment.

LGTM.



================
Comment at: lib/Sema/SemaExprCXX.cpp:2030
+      }
+    }
 
----------------
svenvh wrote:
> rjmccall wrote:
> > Anastasia wrote:
> > > svenvh wrote:
> > > > rjmccall wrote:
> > > > > I think a better interpretation of this rule would be to just error on attempts to use the standard non-placement operator new/delete instead of trying to outlaw the operator declarations.  For example, I don't know why a user-defined non-global operator new would be problematic.
> > > > Good point, I have raised this with Khronos, so I will hold this off until we have clarification.
> > > The decision by Khronos is to allow all user defined new/delete operators (even global). I have submitted the change to the spec. The next publishing date is however in July.
> > Okay.  I agree with your decision in this patch to treat this as a defect in the spec and thus to go ahead and do the right thing now.
> I can postpone committing this until the revised spec has been published, if that's more desirable?
No, if that's the directive I see no reason to wait for formal publication.  As precedent, we update C++ rules long before ISO officially blesses the current draft into a standard.


https://reviews.llvm.org/D46651