[PATCH] D46651: [OpenCL] Support new/delete in Sema

[Sven van Haastregt via Phabricator via cfe-commits]

svenvh added inline comments.


================
Comment at: lib/Sema/SemaExprCXX.cpp:2030
+      }
+    }
 
----------------
rjmccall wrote:
> Anastasia wrote:
> > svenvh wrote:
> > > rjmccall wrote:
> > > > I think a better interpretation of this rule would be to just error on attempts to use the standard non-placement operator new/delete instead of trying to outlaw the operator declarations.  For example, I don't know why a user-defined non-global operator new would be problematic.
> > > Good point, I have raised this with Khronos, so I will hold this off until we have clarification.
> > The decision by Khronos is to allow all user defined new/delete operators (even global). I have submitted the change to the spec. The next publishing date is however in July.
> Okay.  I agree with your decision in this patch to treat this as a defect in the spec and thus to go ahead and do the right thing now.
I can postpone committing this until the revised spec has been published, if that's more desirable?


https://reviews.llvm.org/D46651