[PATCH] D47272: [clangd] Build index on preamble changes instead of the AST changes

Eric Liu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu May 24 06:13:05 PDT 2018

ioeric added a comment.

Would it be possible to add some integration tests for file index plus preamble?

Comment at: clangd/index/FileIndex.cpp:37
+  std::vector<Decl *> TopLevelDecls(
+      AST.getTranslationUnitDecl()->decls().begin(),
+      AST.getTranslationUnitDecl()->decls().end());
Would this give us decls in namespaces? It seems that `AST.getTranslationUnitDecl()->decls()` are only decls that are immediately inside the TU context. 

  rCTE Clang Tools Extra


More information about the cfe-commits mailing list