[PATCH] D47272: [clangd] Build index on preamble changes instead of the AST changes
Ilya Biryukov via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu May 24 07:13:43 PDT 2018
ilya-biryukov added a comment.
In https://reviews.llvm.org/D47272#1110958, @ioeric wrote:
> Would it be possible to add some integration tests for file index plus preamble?
Sure, will do
Comment at: clangd/index/FileIndex.cpp:37
+ std::vector<Decl *> TopLevelDecls(
> Would this give us decls in namespaces? It seems that `AST.getTranslationUnitDecl()->decls()` are only decls that are immediately inside the TU context.
I'll double check and add a test for that, but I think the indexer visits the namespaces that we provide, I'm not sure if we have tests though.
rCTE Clang Tools Extra
More information about the cfe-commits