[PATCH] D46541: [CodeGen] Improve diagnostics related to target attributes

Eric Christopher via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon May 21 02:27:11 PDT 2018

echristo added a comment.

I think this will work, one inline comment. Might also be good to get a few different test cases, e.g. one where we're not seeing the alphabetically first as the minimum :)

Comment at: lib/CodeGen/CodeGenModule.h:1085
+  TargetAttr::ParsedTargetAttr filterFunctionTargetAttrs(const TargetAttr *TD);
Needs a block comment saying what it does :)


More information about the cfe-commits mailing list