[PATCH] D44888: [RISCV] Add -mrelax/-mno-relax flags to enable/disable RISCV linker relaxation

Shiva Chen via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu May 24 23:47:30 PDT 2018

shiva0217 added a comment.

In https://reviews.llvm.org/D44888#1111995, @asb wrote:

> In https://reviews.llvm.org/D44888#1111920, @shiva0217 wrote:
> > In https://reviews.llvm.org/D44888#1109361, @asb wrote:
> >
> > > This is looking good to me, just needs an update to address this <https://reviews.llvm.org/D44888#inline-411895> request for a test in riscv-features.c that demonstrates the default +relax/-relax setting.
> >
> >
> > Hi Alex. I added the testing line on https://reviews.llvm.org/D47127 which is the patch we turn on relaxation as default. Do you think it's ok?
> I saw that. I don't mean to be too nit-picky, but there's an advantage in also testing the default in this patch - it tests the current behaviour and makes it obvious in the follow-up patch that the behaviour actually changed.

OK, make sense to me.



More information about the cfe-commits mailing list