[PATCH] D45884: [Sema] Fix parsing of anonymous union in language linkage specification

Volodymyr Sapsai via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue May 1 16:05:10 PDT 2018


vsapsai added a comment.

In https://reviews.llvm.org/D45884#1084060, @jkorous wrote:

> Volodymyr, could you please confirm that the non-anonymous vs non-inline logic makes sense to you?


Looks correct to me that we are checking non-anonymous namespaces. Inline namespaces are somewhat similar to anonymous namespaces but my testing shows they are working correctly and don't require any change. By "working correctly" I mean

  error: anonymous unions at namespace or global scope must be declared 'static'


https://reviews.llvm.org/D45884





More information about the cfe-commits mailing list